netdev - Re: pull-request: wireless-drivers-next-2020-10-09

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Oct 2020 09:51:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        Luca Coelho <luciano.coelho@...el.com>,
        Mordechay Goodstein <mordechay.goodstein@...el.com>
Subject: Re: pull-request: wireless-drivers-next-2020-10-09

On Fri,  9 Oct 2020 16:07:59 +0000 (UTC) Kalle Valo wrote:
> Hi,
> 
> here's a pull request to net-next tree, more info below. Please let me know if
> there are any problems.
> 
> Kalle
> 
> The following changes since commit c2568c8c9e636a56abf31da4b28b65d3ded02524:
> 
>   Merge branch 'net-Constify-struct-genl_small_ops' (2020-10-04 21:13:36 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git tags/wireless-drivers-next-2020-10-09
> 
> for you to fetch changes up to b7d96bca1f004b5f26ee51ea9c9749a28dac8316:
> 
>   Revert "iwlwifi: remove wide_cmd_header field" (2020-10-09 18:04:50 +0300)

Pulled, thanks Kalle!

Intel folks - do you really need to pack all your structs? 
Do they come from the device unaligned or something?

+/**
+ * struct iwl_statistics_duration_ntfy
+ *
+ * @hdr: general statistics header
+ * @cont_burst_chk_cnt: number of times continuation or
+ *      fragmentation or bursting was checked
+ * @cont_burst_cnt: number of times continuation or fragmentation
+ *      or bursting was successful
+ * @wait_for_silence_timeout_cnt: ???
+ * @reserved: reserved
+ */
+struct iwl_statistics_duration_ntfy {
+       struct iwl_statistics_ntfy_hdr hdr;
+       __le32 cont_burst_chk_cnt;
+       __le32 cont_burst_cnt;
+       __le32 wait_for_silence_timeout_cnt;
+       __le32 reserved;
+} __packed; /* STATISTICS_DURATION_NTFY_API_S_VER_1 */