netdev - Re: [ PATCH v1 1/2] ibmveth: Switch order of ibmveth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Oct 2020 12:49:59 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     David Wilder <dwilder@...ibm.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        tlfalcon@...ux.ibm.com, cris.forno@....com,
        pradeeps@...ux.vnet.ibm.com, wilder@...ibm.com
Subject: Re: [ PATCH v1 1/2] ibmveth: Switch order of ibmveth_helper calls.

On Thu, Oct 8, 2020 at 3:06 PM David Wilder <dwilder@...ibm.com> wrote:
>
> ibmveth_rx_csum_helper() must be called after ibmveth_rx_mss_helper()
> as ibmveth_rx_csum_helper() may alter ip and tcp checksum values.
>
> Signed-off-by: David Wilder <dwilder@...ibm.com>
> Reviewed-by: Thomas Falcon <tlfalcon@...ux.ibm.com>
> Reviewed-by: Cristobal Forno <cris.forno@....com>
> Reviewed-by: Pradeep Satyanarayana <pradeeps@...ux.vnet.ibm.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

(for netdrv)

At first glance the two features sound independent, but this device
may pass mss information through the tcp checksum field. Hence that
must not get overwritten first.

"
        /* if mss is not set through Large Packet bit/mss in rx buffer,
         * expect that the mss will be written to the tcp header checksum.
         */
"