netdev - Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLikuv7Tv1RjYRvvpaL5hk=80uW7ni10L8gkmwG84o6yuYg@mail.gmail.com>
Date:   Sun, 11 Oct 2020 15:18:07 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

On Sun, Oct 11, 2020 at 2:53 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> I'm talking about bnxt_dbg_dump_states specifically.
>
> I'm looking at net-next:
>
>  bnxt_rx_pkt
>    bnxt_sched_reset
>      set_bit(BNXT_RESET_TASK_SP_EVENT, &bp->sp_event);
>
>
>  bnxt_sp_task
>    bnxt_reset
>      bnxt_reset_task
>        bnxt_dbg_dump_states
>
Yes, you are right.  Although, we actually go through a slightly
different path with a different event when we encounter these RX
buffer errors:

bnxt_sched_reset()
  set_bit(BNXT_RST_RING_SP_EVENT, &bp->sp_event)

bnxt_rx_ring_reset()
   bnxt_hwrm_rx_ring_reset()

But with the oldest firmware, this call would fail and we would fall back to

bnxt_reset_task() with non-silent mode.

I will respin and change this call to silent mode.

Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4166 bytes)