netdev - Re: [PATCH net-next v4 10/10] bridge: cfm: Netlink Notifications.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201012130806.sye6tl4amkuqbbgh@soft-test08>
Date:   Mon, 12 Oct 2020 13:08:06 +0000
From:   "henrik.bjoernlund@...rochip.com" <henrik.bjoernlund@...rochip.com>
To:     Nikolay Aleksandrov <nikolay@...dia.com>
CC:     "bridge@...ts.linux-foundation.org" 
        <bridge@...ts.linux-foundation.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Roopa Prabhu <roopa@...dia.com>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "horatiu.vultur@...rochip.com" <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH net-next v4 10/10] bridge: cfm: Netlink Notifications.

The 10/09/2020 22:03, Nikolay Aleksandrov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, 2020-10-09 at 14:35 +0000, Henrik Bjoernlund wrote:
> > This is the implementation of Netlink notifications out of CFM.
> >
> > Notifications are initiated whenever a state change happens in CFM.
> >
> > IFLA_BRIDGE_CFM:
> >     Points to the CFM information.
> >
> > IFLA_BRIDGE_CFM_MEP_STATUS_INFO:
> >     This indicate that the MEP instance status are following.
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO:
> >     This indicate that the peer MEP status are following.
> >
> > CFM nested attribute has the following attributes in next level.
> >
> > IFLA_BRIDGE_CFM_MEP_STATUS_INSTANCE:
> >     The MEP instance number of the delivered status.
> >     The type is NLA_U32.
> > IFLA_BRIDGE_CFM_MEP_STATUS_OPCODE_UNEXP_SEEN:
> >     The MEP instance received CFM PDU with unexpected Opcode.
> >     The type is NLA_U32 (bool).
> > IFLA_BRIDGE_CFM_MEP_STATUS_VERSION_UNEXP_SEEN:
> >     The MEP instance received CFM PDU with unexpected version.
> >     The type is NLA_U32 (bool).
> > IFLA_BRIDGE_CFM_MEP_STATUS_RX_LEVEL_LOW_SEEN:
> >     The MEP instance received CCM PDU with MD level lower than
> >     configured level. This frame is discarded.
> >     The type is NLA_U32 (bool).
> >
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_INSTANCE:
> >     The MEP instance number of the delivered status.
> >     The type is NLA_U32.
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_PEER_MEPID:
> >     The added Peer MEP ID of the delivered status.
> >     The type is NLA_U32.
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_CCM_DEFECT:
> >     The CCM defect status.
> >     The type is NLA_U32 (bool).
> >     True means no CCM frame is received for 3.25 intervals.
> >     IFLA_BRIDGE_CFM_CC_CONFIG_EXP_INTERVAL.
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_RDI:
> >     The last received CCM PDU RDI.
> >     The type is NLA_U32 (bool).
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_PORT_TLV_VALUE:
> >     The last received CCM PDU Port Status TLV value field.
> >     The type is NLA_U8.
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_IF_TLV_VALUE:
> >     The last received CCM PDU Interface Status TLV value field.
> >     The type is NLA_U8.
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_SEEN:
> >     A CCM frame has been received from Peer MEP.
> >     The type is NLA_U32 (bool).
> >     This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO.
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_TLV_SEEN:
> >     A CCM frame with TLV has been received from Peer MEP.
> >     The type is NLA_U32 (bool).
> >     This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO.
> > IFLA_BRIDGE_CFM_CC_PEER_STATUS_SEQ_UNEXP_SEEN:
> >     A CCM frame with unexpected sequence number has been received
> >     from Peer MEP.
> >     The type is NLA_U32 (bool).
> >     When a sequence number is not one higher than previously received
> >     then it is unexpected.
> >     This is cleared after GETLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO.
> >
> > Signed-off-by: Henrik Bjoernlund  <henrik.bjoernlund@...rochip.com>
> > Reviewed-by: Horatiu Vultur  <horatiu.vultur@...rochip.com>
> > ---
> >  net/bridge/br_cfm.c         | 48 ++++++++++++++++++++++++
> >  net/bridge/br_cfm_netlink.c | 25 ++++++++-----
> >  net/bridge/br_netlink.c     | 73 ++++++++++++++++++++++++++++++++-----
> >  net/bridge/br_private.h     | 22 ++++++++++-
> >  4 files changed, 147 insertions(+), 21 deletions(-)
> >
> 
> Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>
> 
Thanks for the review.

-- 
/Henrik