lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 12 Oct 2020 09:33:57 -0400
From:   Willem de Bruijn <>
To:     Tonghao Zhang <>
Cc:     Jason Wang <>,
        "Michael S. Tsirkin" <>,,
        Network Development <>
Subject: Re: [PATCH net-next v3] virtio-net: ethtool configurable RXCSUM

On Sun, Oct 11, 2020 at 10:03 PM <> wrote:
> From: Tonghao Zhang <>
> Allow user configuring RXCSUM separately with ethtool -K,
> reusing the existing virtnet_set_guest_offloads helper
> that configures RXCSUM for XDP. This is conditional on
> If Rx checksum is disabled, LRO should also be disabled.
> Cc: Michael S. Tsirkin <>
> Cc: Jason Wang <>
> Cc: Willem de Bruijn <>
> Signed-off-by: Tonghao Zhang <>
> Acked-by: Michael S. Tsirkin <>

Acked-by: Willem de Bruijn <>

I had to recall why we cannot just rely on dev->features and
dev->hw_features to encode the set of feature capabilities, but need

Flag NETIF_F_LRO encapsulates multiple VIRTIO_NET_F_GUEST_.. flags,
and a device may advertise a subset. We thus have to bound to the set
learned at probing time.

Powered by blists - more mailing lists