lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Oct 2020 09:33:57 -0400 From: Willem de Bruijn <willemdebruijn.kernel@...il.com> To: Tonghao Zhang <xiangxia.m.yue@...il.com> Cc: Jason Wang <jasowang@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>, virtualization@...ts.linux-foundation.org, Network Development <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v3] virtio-net: ethtool configurable RXCSUM On Sun, Oct 11, 2020 at 10:03 PM <xiangxia.m.yue@...il.com> wrote: > > From: Tonghao Zhang <xiangxia.m.yue@...il.com> > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > If Rx checksum is disabled, LRO should also be disabled. > > Cc: Michael S. Tsirkin <mst@...hat.com> > Cc: Jason Wang <jasowang@...hat.com> > Cc: Willem de Bruijn <willemb@...gle.com> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com> > Acked-by: Michael S. Tsirkin <mst@...hat.com> Acked-by: Willem de Bruijn <willemb@...gle.com> I had to recall why we cannot just rely on dev->features and dev->hw_features to encode the set of feature capabilities, but need guest_offloads_capable. Flag NETIF_F_LRO encapsulates multiple VIRTIO_NET_F_GUEST_.. flags, and a device may advertise a subset. We thus have to bound to the set learned at probing time.
Powered by blists - more mailing lists