netdev - Re: [net-next 1/3] i40e: Allow changing FEC settings on X722 if supported by FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76ff76cf5daa54c74e79bea7da9a7ccb8778322c.camel@intel.com>
Date:   Mon, 12 Oct 2020 16:31:37 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>,
        "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>,
        "Gawin, JaroslawX" <jaroslawx.gawin@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrewx.bowers@...el.com" <andrewx.bowers@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [net-next 1/3] i40e: Allow changing FEC settings on X722 if
 supported by FW

On Fri, 2020-10-09 at 16:36 -0700, Jakub Kicinski wrote:
> On Wed,  7 Oct 2020 16:10:48 -0700 Tony Nguyen wrote:
> > +	if (hw->mac.type == I40E_MAC_X722 &&
> > +	    !(hw->flags & I40E_HW_FLAG_X722_FEC_REQUEST_CAPABLE)) {
> > +		netdev_err(netdev, "Setting FEC encoding not supported
> > by firmware. Please update the NVM image.\n");
> > +		return -EINVAL;
> 
> EOPNOTSUPP, since no FEC settings are supported by the device 
> at the time of request.

I'll get this changed.

Thanks,
Tony