lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Oct 2020 11:10:18 -0700 From: John Fastabend <john.fastabend@...il.com> To: Lorenz Bauer <lmb@...udflare.com>, John Fastabend <john.fastabend@...il.com>, Daniel Borkmann <daniel@...earbox.net>, Jakub Sitnicki <jakub@...udflare.com>, Lorenz Bauer <lmb@...udflare.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Yonghong Song <yhs@...com> Cc: kernel-team@...udflare.com, kernel test robot <lkp@...el.com>, netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org Subject: RE: [PATCH bpf] bpf: sockmap: add locking annotations to iterator Lorenz Bauer wrote: > The sparse checker currently outputs the following warnings: > > include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_hash_seq_start' - wrong count at exit > include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_map_seq_start' - wrong count at exit > > Add the necessary __acquires and __release annotations to make the > iterator locking schema palatable to sparse. Also add __must_hold > for good measure. > > The kernel codebase uses both __acquires(rcu) and __acquires(RCU). > I couldn't find any guidance which one is preferred, so I used > what is easier to type out. > > Fixes: 0365351524d7 ("net: Allow iterating sockmap and sockhash") > Reported-by: kernel test robot <lkp@...el.com> > Signed-off-by: Lorenz Bauer <lmb@...udflare.com> > --- LGTM Acked-by: John Fastabend <john.fastabend@...il.com>
Powered by blists - more mailing lists