netdev - Re: [PATCHv3 net-next 02/16] udp6: move the mss check after udp gso tunnel processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSc1FRRZS8Yt0U7bt6M9Qjvi+xrQTefvMuOxF6=FL3dPPw@mail.gmail.com>
Date:   Tue, 13 Oct 2020 13:19:56 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Neil Horman <nhorman@...driver.com>,
        Michael Tuexen <tuexen@...muenster.de>,
        David Miller <davem@...emloft.net>, gnault@...hat.com,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCHv3 net-next 02/16] udp6: move the mss check after udp gso
 tunnel processing

On Tue, Oct 13, 2020 at 3:28 AM Xin Long <lucien.xin@...il.com> wrote:
>
> For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for
> gso_size. When using UDP to encapsulate its packet, it will
> return error in udp6_ufo_fragment() as skb->len < gso_size,
> and it will never go to the gso tunnel processing.
>
> So we should move this check after udp gso tunnel processing,
> the same as udp4_ufo_fragment() does.
>
> v1->v2:
>   - no change.
> v2->v3:
>   - not do any cleanup.
>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks for revising