netdev - Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b07f6cbc-8e48-a4aa-bfcb-8a938fa00a38@infradead.org>
Date:   Tue, 13 Oct 2020 12:35:39 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Dave Ertman <david.m.ertman@...el.com>,
        alsa-devel@...a-project.org
Cc:     parav@...lanox.com, tiwai@...e.de, netdev@...r.kernel.org,
        ranjani.sridharan@...ux.intel.com, fred.oh@...ux.intel.com,
        linux-rdma@...r.kernel.org, dledford@...hat.com,
        broonie@...nel.org, jgg@...dia.com, gregkh@...uxfoundation.org,
        kuba@...nel.org, dan.j.williams@...el.com, shiraz.saleem@...el.com,
        davem@...emloft.net, kiran.patil@...el.com
Subject: Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

On 10/13/20 8:08 AM, Pierre-Louis Bossart wrote:
> 
>>>>>> +config SND_SOC_SOF_CLIENT
>>>>>> +    tristate
>>>>>> +    select ANCILLARY_BUS
>>>>>> +    help
>>>>>> +      This option is not user-selectable but automagically handled by
>>>>>> +      'select' statements at a higher level
>>>>>> +
>>>>>> +config SND_SOC_SOF_CLIENT_SUPPORT
>>>>>> +    bool "SOF enable clients"
>>>>>
>>>>> Tell users what "SOF" means.
>>>>
>>>> This option can only be reached if the user already selected the topic-level option. From there on the SOF acronym is used. Is this not enough?
>>>
>>> Yes, that's enough. I didn't see it. Sorry about that.
>>
>> Huh. I still don't see that Kconfig option.
>> Which patch is it in?
>>
>> I only saw patches 1,2,3 on LKML.
> 
> The Sound Open Firmware (SOF) driver is upstream since 2019, see https://elixir.bootlin.com/linux/latest/source/sound/soc/sof/Kconfig
> 
> What was shared in these patches is just an evolution to make the driver more modular to handle of 'subfunctions' with the auxiliary bus.
> 
> we'd love to hear your feedback if you think the help text can be improved. Thanks!
> 

OK, I looked at the SOF Kconfig files. They are mostly OK except for
missing '.' at the end of lots of sentences and a few other typos.

Do you want patches?

-- 
~Randy