netdev - Re: [Patch net v3] ip_gre: set dev->hard_header_len and dev->needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJht_ENiKS6KKQUCvE1ScLsyTawwaDjioPDC8jXE0CHZKnzHrg@mail.gmail.com>
Date:   Mon, 12 Oct 2020 18:46:47 -0700
From:   Xie He <xie.he.0141@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        syzbot <syzbot+4a2c52677a8a1aa283cb@...kaller.appspotmail.com>,
        William Tu <u9012063@...il.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [Patch net v3] ip_gre: set dev->hard_header_len and
 dev->needed_headroom properly

On Mon, Oct 12, 2020 at 4:17 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> Note, there are some other suspicious use of dev->hard_header_len in
> the same file, but let's leave them to a separate patch if really
> needed.

I looked at the file (before this patch). There are 4 occurrences of
hard_header_len, but they are all for ERSPAN devices (TAP devices
which tunnel Ethernet frames). So I think they are used for the
Ethernet header length and we don't need to worry about them.