lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 14 Oct 2020 12:23:31 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     David Wilder <dwilder@...ibm.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        tlfalcon@...ux.ibm.com, cris.forno@....com,
        pradeeps@...ux.vnet.ibm.com, wilder@...ibm.com,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [ PATCH v2 2/2] ibmveth: Identify ingress large send packets.

On Tue, Oct 13, 2020 at 7:21 PM David Wilder <dwilder@...ibm.com> wrote:
>
> Ingress large send packets are identified by either:
> The IBMVETH_RXQ_LRG_PKT flag in the receive buffer
> or with a -1 placed in the ip header checksum.
> The method used depends on firmware version. Frame
> geometry and sufficient header validation is performed by the
> hypervisor eliminating the need for further header checks here.
>
> Fixes: 7b5967389f5a ("ibmveth: set correct gso_size and gso_type")
> Signed-off-by: David Wilder <dwilder@...ibm.com>
> Reviewed-by: Thomas Falcon <tlfalcon@...ux.ibm.com>
> Reviewed-by: Cristobal Forno <cris.forno@....com>
> Reviewed-by: Pradeep Satyanarayana <pradeeps@...ux.vnet.ibm.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks for clarifying the header validation. I clearly had missed that :)

Powered by blists - more mailing lists