netdev - Re: [PATCH net] net: sched: Fix suspicious RCU usage while accessing tcf_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpV_exrncjYnN1_+gT42uSVGwsFijsu6K1pmYGv9yCBi5Q@mail.gmail.com>
Date:   Wed, 14 Oct 2020 10:37:01 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Leon Romanovsky <leonro@...dia.com>,
        Ido Schimmel <idosch@...dia.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Vlad Buslov <vladbu@...dia.com>
Subject: Re: [PATCH net] net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info

On Wed, Oct 14, 2020 at 1:56 AM Leon Romanovsky <leon@...nel.org> wrote:
>
> From: Leon Romanovsky <leonro@...dia.com>
>
> The access of tcf_tunnel_info() produces the following splat, so fix it
> by dereferencing the tcf_tunnel_key_params pointer with marker that
> internal tcfa_liock is held.

Looks reasonable to me,

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks.