lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Oct 2020 00:53:05 +0200
From:   "Jason A. Donenfeld" <>
To:     Linus Torvalds <>
Cc:     Al Viro <>,
        Linux Kernel Mailing List <>,
        linux-arch <>,
        Netdev <>
Subject: Re: [PATCH v2 20/20] ppc: propagate the calling conventions change
 down to csum_partial_copy_generic()

On Thu, Oct 15, 2020 at 12:51 AM Linus Torvalds
<> wrote:
> On Wed, Oct 14, 2020 at 3:27 PM Jason A. Donenfeld <> wrote:
> >
> > This patch is causing crashes in WireGuard's CI over at
> > . Apparently sending a simple
> > network packet winds up triggering refcount_t's warn-on-saturate code. I
> Ouch.
> The C parts look fairly straightforward, and I don't see how they
> could cause that odd refcount issue.
> So I assume it's the low-level asm code conversion that is buggy. And
> it's apparently the 32-bit conversion, since your ppc64 status looks
> fine.
> I think it's this instruction:
>         addi    r1,r1,16
> that should be removed from the function exit, because Al removed the
> -       stwu    r1,-16(r1)

I just tried that about a minute ago, and indeed that seems to be
what's up. Problem goes away without it. I'll send a patch shortly.


Powered by blists - more mailing lists