lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Oct 2020 15:59:58 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Henrik Bjoernlund <henrik.bjoernlund@...rochip.com> Cc: <davem@...emloft.net>, <roopa@...dia.com>, <nikolay@...dia.com>, <jiri@...lanox.com>, <idosch@...lanox.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <bridge@...ts.linux-foundation.org>, <UNGLinuxDriver@...rochip.com>, Horatiu Vultur <horatiu.vultur@...rochip.com> Subject: Re: [PATCH net-next v5 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added. On Mon, 12 Oct 2020 14:04:23 +0000 Henrik Bjoernlund wrote: > + skb = dev_alloc_skb(CFM_CCM_MAX_FRAME_LENGTH); > + if (!skb) > + return NULL; > + > + rcu_read_lock(); > + b_port = rcu_dereference(mep->b_port); > + if (!b_port) { > + rcu_read_unlock(); > + return NULL; > + } At a quick scan I noticed you appear to be leaking the skb here. So let me point out some more nit picks.
Powered by blists - more mailing lists