netdev - Re: [PATCH v7,net-next,04/13] drivers: crypto: add Marvell OcteonTX2 CPT PF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201014165811.7f2d8ced@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Wed, 14 Oct 2020 16:58:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Srujana Challa <schalla@...vell.com>
Cc:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <sgoutham@...vell.com>, <gakula@...vell.com>,
        <sbhatta@...vell.com>, <schandran@...vell.com>,
        <pathreya@...vell.com>
Subject: Re: [PATCH v7,net-next,04/13] drivers: crypto: add Marvell
 OcteonTX2 CPT PF driver

On Mon, 12 Oct 2020 16:27:10 +0530 Srujana Challa wrote:
> +union otx2_cptx_lf_misc_int {
> +	u64 u;
> +	struct otx2_cptx_lf_misc_int_s {
> +		u64 reserved_0:1;
> +		u64 nqerr:1;
> +		u64 irde:1;
> +		u64 nwrp:1;
> +		u64 reserved_4:1;
> +		u64 hwerr:1;
> +		u64 fault:1;
> +		u64 reserved_7_63:57;
> +	} s;
> +};

AFAIK bitfields don't jive with endianness, please don't use them.
The Linux kernel is supposed to work regardless of host CPU endian.