netdev - Re: [PATCH net-next V2] cxgb4/ch_ipsec: Replace the module name to ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201013173158.4db35480@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 13 Oct 2020 17:31:58 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ayush Sawal <ayush.sawal@...lsio.com>
Cc:     davem@...emloft.net, herbert@...dor.apana.org.au,
        netdev@...r.kernel.org, secdev@...lsio.com
Subject: Re: [PATCH net-next V2] cxgb4/ch_ipsec: Replace the module name to
 ch_ipsec from chcr

On Mon, 12 Oct 2020 12:22:31 +0530 Ayush Sawal wrote:
> This patch changes the module name to "ch_ipsec" and prepends
> "ch_ipsec" string instead of "chcr" in all debug messages and function names.
> 
> V1->V2:
> -Removed inline keyword from functions.
> -Removed CH_IPSEC prefix from pr_debug.
> -Used proper indentation for the continuation line of the function
> arguments.
> 
> Fixes: 1b77be463929 ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net")
> Signed-off-by: Ayush Sawal <ayush.sawal@...lsio.com>

Checkpatch complains about bad indentation:

CHECK: Alignment should match open parenthesis
#282: FILE: drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:408:
+static void *copy_esn_pktxt(struct sk_buff *skb,
+		     struct net_device *dev,

CHECK: Alignment should match open parenthesis
#297: FILE: drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:462:
+static void *copy_cpltx_pktxt(struct sk_buff *skb,
+		       struct net_device *dev,

CHECK: Alignment should match open parenthesis
#312: FILE: drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:506:
+static void *copy_key_cpltx_pktxt(struct sk_buff *skb,
+			   struct net_device *dev,

CHECK: Alignment should match open parenthesis
#328: FILE: drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:554:
+static void *ch_ipsec_crypto_wreq(struct sk_buff *skb,
+			   struct net_device *dev,