netdev - Re: [PATCH net-next] cxgb4: handle 4-tuple PEDIT to NAT mode translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201014182459.68896a93@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 14 Oct 2020 18:24:59 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Herat Ramani <herat@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, rahul@...lsio.com,
        dt@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: handle 4-tuple PEDIT to NAT mode
 translation

On Tue, 13 Oct 2020 15:01:29 +0530 Herat Ramani wrote:
> The 4-tuple NAT offload via PEDIT always overwrites all the 4-tuple
> fields even if they had not been explicitly enabled. If any fields in
> the 4-tuple are not enabled, then the hardware overwrites the
> disabled fields with zeros, instead of ignoring them.
> 
> So, add a parser that can translate the enabled 4-tuple PEDIT fields
> to one of the NAT mode combinations supported by the hardware and
> hence avoid overwriting disabled fields to 0. Any rule with
> unsupported NAT mode combination is rejected.
> 
> Signed-off-by: Herat Ramani <herat@...lsio.com>

Looks good, applied, but to net. 

Not rejecting unsupported configurations is a bug.

Unless you tell me otherwise I'll also queue this for stable.

Thanks!