netdev - Re: [PATCH v2 net-next] net: stmmac: Enable EEE HW LPI timer with auto SW/HW switching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202010160145.wVv6Kqsm-lkp@intel.com>
Date:   Fri, 16 Oct 2020 01:28:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Voon Weifeng <weifeng.voon@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jose Abreu <joabreu@...opsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Andrew Lunn <andrew@...n.ch>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        Voon Weifeng <weifeng.voon@...el.com>
Subject: Re: [PATCH v2 net-next] net: stmmac: Enable EEE HW LPI timer with
 auto SW/HW switching

Hi Voon,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Voon-Weifeng/net-stmmac-Enable-EEE-HW-LPI-timer-with-auto-SW-HW-switching/20201016-000231
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d25e2e9388eda61b6e298585024ee3355f50c493
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b208a1e7f74a391d1d7c2950e35b97c59af55585
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Voon-Weifeng/net-stmmac-Enable-EEE-HW-LPI-timer-with-auto-SW-HW-switching/20201016-000231
        git checkout b208a1e7f74a391d1d7c2950e35b97c59af55585
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:297:6: warning: no previous prototype for 'stmmac_lpi_entry_timer_config' [-Wmissing-prototypes]
     297 | void stmmac_lpi_entry_timer_config(struct stmmac_priv *priv, bool en)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/stmmac_lpi_entry_timer_config +297 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

   296	
 > 297	void stmmac_lpi_entry_timer_config(struct stmmac_priv *priv, bool en)
   298	{
   299		int tx_lpi_timer;
   300	
   301		/* Clear/set the SW EEE timer flag based on LPI ET enablement */
   302		priv->eee_sw_timer_en = en ? 0 : 1;
   303		tx_lpi_timer  = en ? priv->tx_lpi_timer : 0;
   304		stmmac_set_eee_lpi_timer(priv, priv->hw, tx_lpi_timer);
   305	}
   306	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (65141 bytes)