netdev - Re: linux-next: Tree for Oct 15 (drivers/net/pcs/pcs-xpcs.o)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201015180607.xtackyvta7nsiwzh@skbuf>
Date:   Thu, 15 Oct 2020 18:06:08 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Randy Dunlap <rdunlap@...radead.org>
CC:     Jose Abreu <Jose.Abreu@...opsys.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: linux-next: Tree for Oct 15 (drivers/net/pcs/pcs-xpcs.o)

On Thu, Oct 15, 2020 at 10:48:56AM -0700, Randy Dunlap wrote:
> On 10/15/20 10:02 AM, Ioana Ciornei wrote:
> > On Thu, Oct 15, 2020 at 03:06:42PM +0000, Jose Abreu wrote:
> >> From: Randy Dunlap <rdunlap@...radead.org>
> >> Date: Oct/15/2020, 15:45:57 (UTC+00:00)
> >>
> >>> On 10/15/20 12:28 AM, Stephen Rothwell wrote:
> >>>> Hi all,
> >>>>
> >>>> Since the merge window is open, please do not add any v5.11 material to
> >>>> your linux-next included branches until after v5.10-rc1 has been released.
> >>>>
> >>>> News: there will be no linux-next releases next Monday or Tuesday.
> >>>>
> >>>> Changes since 20201013:
> >>>>
> >>>
> >>> on i386:
> >>>
> >>> ld: drivers/net/pcs/pcs-xpcs.o: in function `xpcs_read':
> >>> pcs-xpcs.c:(.text+0x29): undefined reference to `mdiobus_read'
> >>> ld: drivers/net/pcs/pcs-xpcs.o: in function `xpcs_soft_reset.constprop.7':
> >>> pcs-xpcs.c:(.text+0x80): undefined reference to `mdiobus_write'
> >>> ld: drivers/net/pcs/pcs-xpcs.o: in function `xpcs_config_aneg':
> >>> pcs-xpcs.c:(.text+0x318): undefined reference to `mdiobus_write'
> >>> ld: pcs-xpcs.c:(.text+0x38e): undefined reference to `mdiobus_write'
> >>> ld: pcs-xpcs.c:(.text+0x3eb): undefined reference to `mdiobus_write'
> >>> ld: pcs-xpcs.c:(.text+0x437): undefined reference to `mdiobus_write'
> >>> ld: drivers/net/pcs/pcs-xpcs.o:pcs-xpcs.c:(.text+0xb1e): more undefined references to `mdiobus_write' follow
> >>>
> >>>
> > 
> > I think this stems from the fact that PHYLIB is configured as a module
> > which leads to MDIO_BUS being a module as well while the XPCS is still
> > built-in. What should happen in this configuration is that PCS_XPCS
> > should be forced to build as module. However, that select only acts in
> > the opposite way so we should turn it into a depends.
> > 
> > Is the below patch acceptable? If it is, I can submit it properly.
> 
> Hi,
> Did you copy-paste this patch?  It contains spaces instead of tabs
> so it doesn't apply cleanly/easily, but I managed to apply and test it, so
> 

Yes, it was a quick copy-paste. Sorry for the trouble.

> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
> 

Thanks.

Ioana