netdev - Re: [PATCH ethtool] netlink: fix allocation failure handling in dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160278780283.28012.6567583320815769774.git-patchwork-notify@kernel.org>
Date:   Thu, 15 Oct 2020 18:50:02 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org, ivecera@...hat.com
Subject: Re: [PATCH ethtool] netlink: fix allocation failure handling in
 dump_features()

Hello:

This patch was applied to ethtool/ethtool.git (refs/heads/master):

On Wed, 14 Oct 2020 18:49:52 +0200 (CEST) you wrote:
> On allocation failure, dump_features() would set ret to -ENOMEM but then
> return 0 anyway. As there is nothing to free in this case anyway, the
> easiest fix is to simply return -ENOMEM rather than jumping to out_free
> label - which can be dropped as well as this was its only use.
> 
> Fixes: f2c17e107900 ("netlink: add netlink handler for gfeatures (-k)")
> Reported-by: Ivan Vecera <ivecera@...hat.com>
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> 
> [...]

Here is the summary with links:
  - [ethtool] netlink: fix allocation failure handling in dump_features()
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=09c67a720a07

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html