netdev - Re: [PATCH] net: sockmap: Don't call bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160278900298.4062.17082299733897692954.git-patchwork-notify@kernel.org>
Date:   Thu, 15 Oct 2020 19:10:02 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Alex Dewar <alex.dewar90@...il.com>
Cc:     john.fastabend@...il.com, daniel@...earbox.net,
        jakub@...udflare.com, lmb@...udflare.com, davem@...emloft.net,
        kuba@...nel.org, ast@...nel.org, kafai@...com,
        songliubraving@...com, yhs@...com, andrii@...nel.org,
        kpsingh@...omium.org, netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sockmap: Don't call bpf_prog_put() on NULL pointer

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Mon, 12 Oct 2020 18:09:53 +0100 you wrote:
> If bpf_prog_inc_not_zero() fails for skb_parser, then bpf_prog_put() is
> called unconditionally on skb_verdict, even though it may be NULL. Fix
> and tidy up error path.
> 
> Addresses-Coverity-ID: 1497799: Null pointer dereferences (FORWARD_NULL)
> Fixes: 743df8b7749f ("bpf, sockmap: Check skb_verdict and skb_parser programs explicitly")
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> 
> [...]

Here is the summary with links:
  - net: sockmap: Don't call bpf_prog_put() on NULL pointer
    https://git.kernel.org/bpf/bpf-next/c/83c11c17553c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html