netdev - Re: [PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f87cefaa8401_b7602084e@john-XPS-13-9370.notmuch>
Date:   Wed, 14 Oct 2020 21:24:26 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Song Liu <songliubraving@...com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>
Cc:     Kernel Team <Kernel-team@...com>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "kpsingh@...omium.org" <kpsingh@...omium.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: fix compilation error in
 progs/profiler.inc.h

Song Liu wrote:
> 
> 
> > On Oct 13, 2020, at 9:36 PM, Song Liu <songliubraving@...com> wrote:
> > 
> > Fix the following error when compiling selftests/bpf
> > 
> > progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as different kind of symbol
> > 
> > pids_cgrp_id is used in cgroup code, and included in vmlinux.h. Fix the
> > error by renaming pids_cgrp_id as pids_cgroup_id.
> > 
> > Fixes: 03d4d13fab3f ("selftests/bpf: Add profiler test")
> > Signed-off-by: Song Liu <songliubraving@...com>
> 
> I forgot to mention
> 
> Reported-by: Jiri Olsa <jolsa@...nel.org>

Acked-by: John Fastabend <john.fastabend@...il.com>