lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Oct 2020 05:50:34 +0000 From: Song Liu <songliubraving@...com> To: Alexei Starovoitov <alexei.starovoitov@...il.com> CC: Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, Kernel Team <Kernel-team@...com>, Alexei Starovoitov <ast@...nel.org>, "Daniel Borkmann" <daniel@...earbox.net>, "john.fastabend@...il.com" <john.fastabend@...il.com>, "kpsingh@...omium.org" <kpsingh@...omium.org> Subject: Re: [PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h > On Oct 14, 2020, at 9:29 PM, Alexei Starovoitov <alexei.starovoitov@...il.com> wrote: > > On Tue, Oct 13, 2020 at 09:36:38PM -0700, Song Liu wrote: >> Fix the following error when compiling selftests/bpf >> >> progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as different kind of symbol >> >> pids_cgrp_id is used in cgroup code, and included in vmlinux.h. Fix the >> error by renaming pids_cgrp_id as pids_cgroup_id. >> >> Fixes: 03d4d13fab3f ("selftests/bpf: Add profiler test") >> Signed-off-by: Song Liu <songliubraving@...com> >> --- >> tools/testing/selftests/bpf/progs/profiler.inc.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/bpf/progs/profiler.inc.h b/tools/testing/selftests/bpf/progs/profiler.inc.h >> index 00578311a4233..b554c1e40b9fb 100644 >> --- a/tools/testing/selftests/bpf/progs/profiler.inc.h >> +++ b/tools/testing/selftests/bpf/progs/profiler.inc.h >> @@ -243,7 +243,7 @@ static ino_t get_inode_from_kernfs(struct kernfs_node* node) >> } >> } >> >> -int pids_cgrp_id = 1; >> +int pids_cgroup_id = 1; > > I would prefer to try one of three options that Andrii suggested. Ah, I missed that email (because of vger lag, I guess). Just verified Andrii's version works. Thanks, Song
Powered by blists - more mailing lists