netdev - Re: [PATCH net-next 3/9] net: 8021q: resolve forwarding path for vlan devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Oct 2020 15:48:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>,
        netfilter-devel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net,
        netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH net-next 3/9] net: 8021q: resolve forwarding path for
 vlan devices

Hi Pablo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-flowtable-bridge-and-vlan-enhancements/20201015-091818
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 50172733d01c3097b23ac8d45bf1fff72af0ba98
config: riscv-randconfig-s031-20201015 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-rc1-dirty
        # https://github.com/0day-ci/linux/commit/fbe6da32dfe77e080e449951ba7a5d3308938304
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-flowtable-bridge-and-vlan-enhancements/20201015-091818
        git checkout fbe6da32dfe77e080e449951ba7a5d3308938304
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


"sparse warnings: (new ones prefixed by >>)"
>> net/8021q/vlan_dev.c:776:23: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __be16 [usertype] id @@     got unsigned short [usertype] vlan_id @@
>> net/8021q/vlan_dev.c:776:23: sparse:     expected restricted __be16 [usertype] id
>> net/8021q/vlan_dev.c:776:23: sparse:     got unsigned short [usertype] vlan_id

vim +776 net/8021q/vlan_dev.c

   769	
   770	static int vlan_dev_fill_forward_path(struct net_device_path_ctx *ctx,
   771					      struct net_device_path *path)
   772	{
   773		struct vlan_dev_priv *vlan = vlan_dev_priv(ctx->dev);
   774	
   775		path->type = DEV_PATH_VLAN;
 > 776		path->vlan.id = vlan->vlan_id;
   777		path->vlan.proto = vlan->vlan_proto;
   778		path->dev = ctx->dev;
   779		ctx->dev = vlan->real_dev;
   780	
   781		return 0;
   782	}
   783	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (31027 bytes)