lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Oct 2020 11:24:13 +0000 From: Henrik Bjoernlund <henrik.bjoernlund@...rochip.com> To: Jakub Kicinski <kuba@...nel.org> CC: <davem@...emloft.net>, <roopa@...dia.com>, <nikolay@...dia.com>, <jiri@...lanox.com>, <idosch@...lanox.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <bridge@...ts.linux-foundation.org>, <UNGLinuxDriver@...rochip.com>, Horatiu Vultur <horatiu.vultur@...rochip.com> Subject: Re: [PATCH net-next v5 08/10] bridge: cfm: Netlink GET configuration Interface. Thanks for your review. Comment below. Regards Henrik The 10/14/2020 16:33, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, 12 Oct 2020 14:04:26 +0000 Henrik Bjoernlund wrote: > > + if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_SEQ_NO_UPDATE, > > + mep->cc_ccm_tx_info.seq_no_update)) > > + goto nla_put_failure; > > + > > + if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_PERIOD, > > + mep->cc_ccm_tx_info.period)) > > + goto nla_put_failure; > > + > > + if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_IF_TLV, > > + mep->cc_ccm_tx_info.if_tlv)) > > + goto nla_put_failure; > > + > > + if (nla_put_u8(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_IF_TLV_VALUE, > > + mep->cc_ccm_tx_info.if_tlv_value)) > > + goto nla_put_failure; > > + > > + if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_PORT_TLV, > > + mep->cc_ccm_tx_info.port_tlv)) > > + goto nla_put_failure; > > + > > + if (nla_put_u8(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_PORT_TLV_VALUE, > > + mep->cc_ccm_tx_info.port_tlv_value)) > > + goto nla_put_failure; > > Consider collapsing writing related attrs in a nest into a single > if statement: > > if (nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_SEQ_NO_UPDATE, > mep->cc_ccm_tx_info.seq_no_update) || > nla_put_u32(skb, IFLA_BRIDGE_CFM_CC_CCM_TX_PERIOD, > mep->cc_ccm_tx_info.period) || > ... I will prefer to keep it as is for my personal taste :-) -- /Henrik
Powered by blists - more mailing lists