netdev - Re: [PATCH net] net: dsa: point out the tail taggers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Oct 2020 19:56:51 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Christian Eggers <ceggers@...i.de>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: point out the tail taggers

Hi Christian,

On Fri, Oct 16, 2020 at 06:28:00PM +0200, Christian Eggers wrote:
> From a  recent commit with the same summary:
> 
> "The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and
> KSZ9893 switches also use tail tags."
> 
> Set "tail_tag" to true for KSZ8795 and KSZ9477 which were missing in the
> original commit.
> 
> Fixes: 7a6ffe764be3 [net] ("net: dsa: point out the tail taggers")
> Signed-off-by: Christian Eggers <ceggers@...i.de>
> ---

The idea is perfect but the commit isn't.

First of all, put this in your .gitconfig.

[core]
	abbrev = 12
[pretty]
	fixes = Fixes: %h (\"%s\")

Now if you run
"git show 7a6ffe764be35af0527d8cfd047945e8f8797ddf --pretty=fixes",
you'll see:

Fixes: 7a6ffe764be3 ("net: dsa: point out the tail taggers")

Notice how there's no [net] tag?
People complain when the format of the Fixes: tag is not standardized.

Secondly, can you please come up with a commit description that is
_different_ from the commit you're fixing? As a backporter I would hate
to have 2 commits with the same title, I would surely mess them up.

How about:
net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags