netdev - Re: [PATCH net] icmp: randomize the global rate limiter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201016164909.45d02606@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 16 Oct 2020 16:49:09 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>, Keyu Man <kman001@....edu>
Subject: Re: [PATCH net] icmp: randomize the global rate limiter

On Thu, 15 Oct 2020 11:42:00 -0700 Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> Keyu Man reported that the ICMP rate limiter could be used
> by attackers to get useful signal. Details will be provided
> in an upcoming academic publication.
> 
> Our solution is to add some noise, so that the attackers
> no longer can get help from the predictable token bucket limiter.
> 
> Fixes: 4cdf507d5452 ("icmp: add a global rate limitation")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Keyu Man <kman001@....edu>

Applied, queued up, thank you!