lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 16 Oct 2020 06:52:23 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Peng Fan <peng.fan@....com>, Ying Liu <victor.liu@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Pankaj Bansal <pankaj.bansal@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index
 property to indicate a resource


Hi Marc,

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Sent: 2020年10月16日 14:20
> To: Joakim Zhang <qiangqing.zhang@....com>; robh+dt@...nel.org;
> shawnguo@...nel.org; s.hauer@...gutronix.de
> Cc: devicetree@...r.kernel.org; Peng Fan <peng.fan@....com>; Ying Liu
> <victor.liu@....com>; netdev@...r.kernel.org; Pankaj Bansal
> <pankaj.bansal@....com>; linux-kernel@...r.kernel.org;
> linux-can@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> kernel@...gutronix.de
> Subject: Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property
> to indicate a resource
> 
> On 10/16/20 3:43 PM, Joakim Zhang wrote:
> > For SoCs with SCU support, need setup stop mode via SCU firmware, so
> > this property can help indicate a resource.
> >
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> > ---
> >  Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > index 6af67f5e581c..839c0c0064a2 100644
> > --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > @@ -43,6 +43,10 @@ Optional properties:
> >  		  0: clock source 0 (oscillator clock)
> >  		  1: clock source 1 (peripheral clock)
> >
> > +- fsl,can-index: The index of CAN instance.
> > +                 For SoCs with SCU support, need setup stop mode via
> SCU firmware,
> > +                 so this property can help indicate a resource.
> 
> This property is not CAN specific. So the name could be more general.

How about "fsl,index"?

Best Regards,
Joakim Zhang
> > +
> >  - wakeup-source: enable CAN remote wakeup
> >
> >  Example:
> > @@ -54,4 +58,5 @@ Example:
> >  		interrupt-parent = <&mpic>;
> >  		clock-frequency = <200000000>; // filled in by bootloader
> >  		fsl,clk-source = /bits/ 8 <0>; // select clock source 0 for PE
> > +		fsl,can-index = /bits/ 8 <1>; // the second CAN instance
> >  	};
> >
> 
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Powered by blists - more mailing lists