lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 16 Oct 2020 09:47:14 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Joakim Zhang <qiangqing.zhang@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Peng Fan <peng.fan@....com>, Ying Liu <victor.liu@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Pankaj Bansal <pankaj.bansal@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index
 property to indicate a resource

On 10/16/20 8:52 AM, Joakim Zhang wrote:
> 
> Hi Marc,
> 
>> -----Original Message-----
>> From: Marc Kleine-Budde <mkl@...gutronix.de>
>> Sent: 2020年10月16日 14:20
>> To: Joakim Zhang <qiangqing.zhang@....com>; robh+dt@...nel.org;
>> shawnguo@...nel.org; s.hauer@...gutronix.de
>> Cc: devicetree@...r.kernel.org; Peng Fan <peng.fan@....com>; Ying Liu
>> <victor.liu@....com>; netdev@...r.kernel.org; Pankaj Bansal
>> <pankaj.bansal@....com>; linux-kernel@...r.kernel.org;
>> linux-can@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
>> kernel@...gutronix.de
>> Subject: Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property
>> to indicate a resource
>>
>> On 10/16/20 3:43 PM, Joakim Zhang wrote:
>>> For SoCs with SCU support, need setup stop mode via SCU firmware, so
>>> this property can help indicate a resource.
>>>
>>> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
>>> ---
>>>  Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>>> b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>>> index 6af67f5e581c..839c0c0064a2 100644
>>> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>>> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>>> @@ -43,6 +43,10 @@ Optional properties:
>>>  		  0: clock source 0 (oscillator clock)
>>>  		  1: clock source 1 (peripheral clock)
>>>
>>> +- fsl,can-index: The index of CAN instance.
>>> +                 For SoCs with SCU support, need setup stop mode via
>> SCU firmware,
>>> +                 so this property can help indicate a resource.
>>
>> This property is not CAN specific. So the name could be more general.
> 
> How about "fsl,index"?

Maybe something with "scu", as it's specific to the SCU firmware.

I think it's up to Rob's and the DT people.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists