lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Oct 2020 17:34:58 -0700 From: Jesse Brandeburg <jesse.brandeburg@...el.com> To: Jakub Kicinski <kuba@...nel.org> Cc: Ian Rogers <irogers@...gle.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andrii@...nel.org>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, "David S. Miller" <davem@...emloft.net>, Igor Russkikh <irusskikh@...vell.com>, Mark Starovoytov <mstarovoitov@...vell.com>, Horatiu Vultur <horatiu.vultur@...rochip.com>, Antoine Tenart <antoine.tenart@...tlin.com>, "Toke Høiland-Jørgensen\" <toke@...hat.com>, Nikolay Aleksandrov <nikolay@...ulusnetworks.com>, Roopa Prabhu <roopa@...ulusnetworks.com>, Jiri Pirko <jiri@...lanox.com>, Vlad Buslov <vladbu@...lanox.com>, Ido Schimmel <idosch@...lanox.com>, Alexandre Cassen <acassen@...il.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, bpf@...r.kernel.org Subject: Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h Jakub Kicinski wrote: > On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote: > > > These are tested to be the latest as part of the tools/lib/bpf build. > > > > But you didn't mention why you're making these changes, and you're > > removing a lot of comments without explaining why/where there might be > > a replacement or why the comments are useless. I now see that you're > > adding actual kdoc which is good, except for the part where > > you don't put kdoc on all the structures. > > Note that he's just syncing the uAPI headers to tools/ > > The source of the change is here: > > 78a3ea555713 ("net: remove comments on struct rtnl_link_stats") > 0db0c34cfbc9 ("net: tighten the definition of interface statistics") Thanks Kuba, I'm not trying to be a hard ass, but the commit message didn't say why he's making the change, and if I bisect back to this and see "sync" as the commit message, I think I'd be stuck chasing "sync to what?" I guess that his changelog could just say what you said? Proposed: Sync the uAPI headers so that userspace and the kernel match. These changes match the updates to the files in the tools directory that were already updated by commits: 78a3ea555713 ("net: remove comments on struct rtnl_link_stats") 0db0c34cfbc9 ("net: tighten the definition of interface statistics")
Powered by blists - more mailing lists