netdev - Re: [PATCH net] ixgbe: fix probing of multi-port devices with one MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201018130410.6bc9672e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 18 Oct 2020 13:04:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:     Ian Kumlien <ian.kumlien@...il.com>, anthony.l.nguyen@...el.com,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        kernel-team@...com, Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH net] ixgbe: fix probing of multi-port devices with one
 MDIO

On Fri, 16 Oct 2020 17:48:07 -0700 Jesse Brandeburg wrote:
> Jakub Kicinski wrote:
> 
> > On Sat, 17 Oct 2020 01:50:59 +0200 Ian Kumlien wrote:  
> > > On Sat, Oct 17, 2020 at 1:20 AM Jakub Kicinski <kuba@...nel.org> wrote:  
> > > > Ian reports that after upgrade from v5.8.14 to v5.9 only one
> > > > of his 4 ixgbe netdevs appear in the system.
> > > >
> > > > Quoting the comment on ixgbe_x550em_a_has_mii():
> > > >  * Returns true if hw points to lowest numbered PCI B:D.F x550_em_a device in
> > > >  * the SoC.  There are up to 4 MACs sharing a single MDIO bus on the x550em_a,
> > > >  * but we only want to register one MDIO bus.
> > > >
> > > > This matches the symptoms, since the return value from
> > > > ixgbe_mii_bus_init() is no longer ignored we need to handle
> > > > the higher ports of x550em without an error.    
> > > 
> > > Nice, that fixes it!
> > > 
> > > You can add a:
> > > Tested-by: Ian Kumlien <ian.kumlien@...il.com>  
> > 
> > Will do, thanks!
> > 
> > Tony, should I apply directly to net?  
> 
> Thank you Kuba!
> 
> Seems like a pretty straight forward bug-fix. I recommend
> you apply it directly.

Done.

> Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com>

Thank you!