netdev - Re: [PATCH net] net: core: use list_del_init() instead of list_del() in netdev_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201018145327.52595f4f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 18 Oct 2020 14:53:27 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Taehee Yoo <ap420073@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: core: use list_del_init() instead of
 list_del() in netdev_run_todo()

On Thu, 15 Oct 2020 16:26:06 +0000 Taehee Yoo wrote:
> dev->unlink_list is reused unless dev is deleted.
> So, list_del() should not be used.
> Due to using list_del(), dev->unlink_list can't be reused so that
> dev->nested_level update logic doesn't work.
> In order to fix this bug, list_del_init() should be used instead
> of list_del().

Applied, thanks!