netdev - Re: [PATCH v2 0/6] igb: xdp patches followup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 18 Oct 2020 15:39:51 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To:     sven.auhagen@...eatech.de
Cc:     anthony.l.nguyen@...el.com, davem@...emloft.net,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com,
        sandeep.penigalapati@...el.com, brouer@...hat.com
Subject: Re: [PATCH v2 0/6] igb: xdp patches followup

On Sat, Oct 17, 2020 at 09:12:32AM +0200, sven.auhagen@...eatech.de wrote:
> From: Sven Auhagen <sven.auhagen@...eatech.de>
> 
> This patch series addresses some of the comments that came back
> after the igb XDP patch was accepted.
> Most of it is code cleanup.
> The last patch contains a fix for a tx queue timeout
> that can occur when using xdp.
> 
> Signed-off-by: Sven Auhagen <sven.auhagen@...eatech.de>

Sorry for not getting back at v1 discussion, I took some time off.

For the series:
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

Couple nits:
- you don't need SOB line within cover letter, I suppose
- next time please specify the tree in the subject that you're targetting
  this set to land; is it net or net-next? net-next is currently closed so
  you probably would have to come back with this once it will be open
  again
- SOB line should be at the end of tags within commit message of patch;
  I'm saying 'should' because I'm not sure if it's hard requirement.

> 
> Change from v1:
>     * Drop patch 5 as the igb_rx_frame_truesize won't match
>     * Fix typo in comment
>     * Add Suggested-by and Reviewed-by tags
>     * Add how to avoid transmit queue timeout in xdp path
>       is fixed in the commit message
> 
> Sven Auhagen (6):
>   igb: XDP xmit back fix error code
>   igb: take vlan double header into account
>   igb: XDP extack message on error
>   igb: skb add metasize for xdp
>   igb: use xdp_do_flush
>   igb: avoid transmit queue timeout in xdp path
> 
>  drivers/net/ethernet/intel/igb/igb.h      |  5 ++++
>  drivers/net/ethernet/intel/igb/igb_main.c | 32 +++++++++++++++--------
>  2 files changed, 26 insertions(+), 11 deletions(-)
> 
> -- 
> 2.20.1
>