netdev - Re: [RFC PATCH 01/13] net: dsa: add plumbing for custom netdev statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201018113305.091946ff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 18 Oct 2020 11:33:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        f.fainelli@...il.com, vivien.didelot@...il.com,
        Christian Eggers <ceggers@...i.de>,
        Kurt Kanzenbach <kurt@...utronix.de>
Subject: Re: [RFC PATCH 01/13] net: dsa: add plumbing for custom netdev
 statistics

On Sun, 18 Oct 2020 11:26:53 -0700 Jakub Kicinski wrote:
> Hm, looks like the intent is to enforce power of two alignment 
> to prevent the structure from spanning cache lines. Doesn't make 
> any difference for 1 counter, but I guess we can keep the style 
> for consistency.

I take that back, looks like seqcount_t is 4B, so it will make
a difference, don't mind me :)