netdev - Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201018185943.GM20115@casper.infradead.org>
Date:   Sun, 18 Oct 2020 19:59:43 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     trix@...hat.com
Cc:     linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        clang-built-linux@...glegroups.com, linux-iio@...r.kernel.org,
        nouveau@...ts.freedesktop.org, storagedev@...rochip.com,
        dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        keyrings@...r.kernel.org, linux-mtd@...ts.infradead.org,
        ath10k@...ts.infradead.org, MPT-FusionLinux.pdl@...adcom.com,
        linux-stm32@...md-mailman.stormreply.com,
        usb-storage@...ts.one-eyed-alien.net,
        linux-watchdog@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-samsung-soc@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-nvdimm@...ts.01.org, amd-gfx@...ts.freedesktop.org,
        linux-acpi@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
        industrypack-devel@...ts.sourceforge.net,
        linux-pci@...r.kernel.org, spice-devel@...ts.freedesktop.org,
        linux-media@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-nfc@...ts.01.org, linux-pm@...r.kernel.org,
        linux-can@...r.kernel.org, linux-block@...r.kernel.org,
        linux-gpio@...r.kernel.org, xen-devel@...ts.xenproject.org,
        linux-amlogic@...ts.infradead.org,
        openipmi-developer@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org,
        linux-integrity@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-edac@...r.kernel.org,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-wireless@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-crypto@...r.kernel.org, patches@...nsource.cirrus.com,
        bpf@...r.kernel.org, ocfs2-devel@....oracle.com,
        linux-power@...rohmeurope.com
Subject: Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

On Sat, Oct 17, 2020 at 09:09:28AM -0700, trix@...hat.com wrote:
> clang has a number of useful, new warnings see
> https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F98FupVhj_jxX60ddN6tKGEbv_cnooXc1nnBmchm-e_O9ieGnyQ$ 

Please get your IT department to remove that stupidity.  If you can't,
please send email from a non-Red Hat email address.

I don't understand why this is a useful warning to fix.  What actual
problem is caused by the code below?

> return and break
> 
>  	switch (c->x86_vendor) {
>  	case X86_VENDOR_INTEL:
>  		intel_p5_mcheck_init(c);
>  		return 1;
> -		break;

Sure, it's unnecessary, but it's not masking a bug.  It's not unclear.
Why do we want to enable this warning?