netdev - Re: [PATCH] net: phy: marvell: add special handling of Finisar modules with 81E1111

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b4102af1c7c19822a9b29f4a9c84da56c9269dd.camel@calian.com>
Date:   Mon, 19 Oct 2020 22:11:32 +0000
From:   Robert Hancock <robert.hancock@...ian.com>
To:     "andrew@...n.ch" <andrew@...n.ch>
CC:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: phy: marvell: add special handling of Finisar
 modules with 81E1111

On Mon, 2020-10-19 at 23:59 +0200, Andrew Lunn wrote:
> > I suppose that part would be pretty harmless, as you would likely
> > want
> > that behavior whenever that if condition was triggered. So
> > m88e1111_finisar_config_init could likely be merged into
> > m88e1111_config_init.
> 
> I think so as well.
> 
> > Mainly what stopped me from making all of these changes generic to
> > all
> > 88E1111 is that I'm a bit less confident in the different
> > config_aneg
> > behavior, it might be more specific to this SFP copper module
> > case? 
> 
> Well, for 1000BaseX, i don't think we currently have an SFP devices
> using it, since phylink does not support it. So it is a question are
> there any none-SFP m88e1111 out there you might break?

Yeah, I don't really know the answer to that question as I'm not
familiar with all the other setups where this part would be used. So
I'm inclined to leave that part specific to this ID.

-- 
Robert Hancock
Senior Hardware Designer, Advanced Technologies 
www.calian.com