netdev - Re: [PATCHv4 net-next 07/16] sctp: add encap_port for netns sock asoc and transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201019221429.GC11030@localhost.localdomain>
Date:   Mon, 19 Oct 2020 19:14:29 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>,
        Michael Tuexen <tuexen@...muenster.de>, davem@...emloft.net,
        gnault@...hat.com, pabeni@...hat.com,
        willemdebruijn.kernel@...il.com
Subject: Re: [PATCHv4 net-next 07/16] sctp: add encap_port for netns sock
 asoc and transport

On Mon, Oct 19, 2020 at 08:25:24PM +0800, Xin Long wrote:
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -2640,6 +2640,15 @@ addr_scope_policy - INTEGER
>  
>  	Default: 1
>  
> +encap_port - INTEGER
> +	The default remote UDP encapsalution port.
                                     ^^^ typo

> +	When UDP tunneling is enabled, this global value is used to set
> +	the dest port for the udp header of outgoing packets by default.
                              ^^^ uppercase as well
> +	Users can also change the value for each sock/asoc/transport by
> +	using setsockopt.

Please also add something like:
	For further information, please refer to RFC6951.

> +
> +	Default: 0
> +