lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 19 Oct 2020 15:49:33 -0700
From:   Jakub Kicinski <>
To:     Xie He <>
Cc:     "David S. Miller" <>,
        Linux Kernel Network Developers <>,
        LKML <>,
        Krzysztof Halasa <>
Subject: Re: [PATCH net] drivers/net/wan/hdlc: In hdlc_rcv, check to make
 sure dev is an HDLC device

On Mon, 19 Oct 2020 15:36:14 -0700 Xie He wrote:
> On Mon, Oct 19, 2020 at 2:22 PM Jakub Kicinski <> wrote:
> >
> > Looks correct to me. I spotted there is also IFF_WAN_HDLC added by
> > 7cdc15f5f9db ("WAN: Generic HDLC now uses IFF_WAN_HDLC private flag.")
> > would using that flag also be correct and cleaner potentially?
> >
> > Up to you, just wanted to make sure you considered it.  
> Oh, Yes! I see IFF_WAN_HDLC is set for all HDLC devices. I also
> searched through the kernel code and see no other uses of
> IFF_WAN_HDLC. So I think we can use IFF_WAN_HDLC to reliably check if
> a device is an HDLC device. This should be cleaner than checking
> ndo_start_xmit.
> Thanks! I'll change this patch to use IFF_WAN_HDLC.

Cool! FWIW when you resend you can also trim the subject to just say:

net: hdlc: In hdlc_rcv, check to make sure dev is an HDLC device

There's no need for the full file path.

Powered by blists - more mailing lists