netdev - Re: [PATCH net] r8169: fix operation under forced interrupt threading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201019165845.61fe6b6e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 19 Oct 2020 16:58:45 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] r8169: fix operation under forced interrupt
 threading

On Sun, 18 Oct 2020 18:38:59 +0200 Heiner Kallweit wrote:
> For several network drivers it was reported that using
> __napi_schedule_irqoff() is unsafe with forced threading. One way to
> fix this is switching back to __napi_schedule, but then we lose the
> benefit of the irqoff version in general. As stated by Eric it doesn't
> make sense to make the minimal hard irq handlers in drivers using NAPI
> a thread. Therefore ensure that the hard irq handler is never
> thread-ified.
> 
> Fixes: 9a899a35b0d6 ("r8169: switch to napi_schedule_irqoff")
> Link: https://lkml.org/lkml/2020/10/18/19
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thank you!