lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 20 Oct 2020 02:58:08 +0200
From:   Petr Machata <me@...chata.org>
To:     netdev@...r.kernel.org, dsahern@...il.com,
        stephen@...workplumber.org
Cc:     john.fastabend@...il.com, jiri@...dia.com, idosch@...dia.com,
        Petr Machata <me@...chata.org>
Subject: [PATCH iproute2-next 00/15] Add a tool for configuration of DCB

The Linux DCB interface allows configuration of a broad range of
hardware-specific attributes, such as TC scheduling, flow control, per-port
buffer configuration, TC rate, etc.

Currently a common libre tool for configuration of DCB is OpenLLDP. This
suite contains a daemon that uses Linux DCB interface to configure HW
according to the DCB TLVs exchanged over an interface. The daemon can also
be controlled by a client, through which the user can adjust and view the
configuration. The downside of using OpenLLDP is that it is somewhat
heavyweight and difficult to use in scripts, and does not support
extensions such as buffer and rate commands.

For access to many HW features, one would be perfectly fine with a
fire-and-forget tool along the lines of "ip" or "tc". For scripting in
particular, this would be ideal. This author is aware of one such tool,
mlnx_qos from Mellanox OFED scripts collection[1].

The downside here is that the tool is very verbose, the command line
language is awkward to use, it is not packaged in Linux distros, and
generally has the appearance of a very vendor-specific tool, despite not
being one.

This patchset addresses the above issues by providing a seed of a clean,
well-documented, easily usable, extensible fire-and-forget tool for DCB
configuration:

    # dcb ets set dev eni1np1 \
                  tc-tsa all:strict 0:ets 1:ets 2:ets \
		  tc-bw all:0 0:33 1:33 2:34

    # dcb ets show dev eni1np1 tc-tsa tc-bw
    tc-tsa 0:ets 1:ets 2:ets 3:strict 4:strict 5:strict 6:strict 7:strict
    tc-bw 0:33 1:33 2:34 3:0 4:0 5:0 6:0 7:0

    # dcb ets set dev eni1np1 tc-bw 1:30 2:37

    # dcb -j ets show dev eni1np1 | jq '.["tc-bw"]["2"]'
    37

The patchset proceeds as follows:

- Many tools in iproute2 have an option to work in batch mode, where the
  commands to run are given in a file. The code to handle batching is
  largely the same independent of the tool in question. In patch #1, add a
  helper to handle the batching, and migrate individual tools to use it.

- A number of configuration options come in a form of an on-off switch.
  This in turn can be considered a special case of parsing one of a given
  set of strings. Currently each tool open-codes the logic to parse the
  on-off toggle. And on top of the on-off parsing, tools have logic to set
  or unset a flag according to the keyword parsed.

  In patches #2-#7, extract helpers to parse one of a number of strings, on
  top of which build an on-off parser, on top of which build a flag set /
  unset handler. Then migrate all known instances of this code over to the
  new helpers.

- The DCB tool is built on top of libmnl. Several routines will be
  basically the same in DCB as they are currently in devlink. In patches
  #8-#10, extract them to a new module, mnl_utils, for easy reuse.

- Much of DCB is built around arrays. A syntax similar to the iplink_vlan's
  ingress-qos-map / egress-qos-map is very handy for describing changes
  done to such arrays. Therefore in patch #11, extract a helper,
  parse_mapping(), which manages parsing of key-value arrays. In patch #12,
  fix a buglet in the helper, and in patch #13, extend it to allow setting
  of all array elements in one go.

- In patch #14, add a skeleton of "dcb", which contains common helpers and
  dispatches to subtools for handling of individual objects. The skeleton
  is empty as of this patch.

  In patch #15, add "dcb_ets", a module for handling of specifically DCB
  ETS objects.

The intention is to gradually add handlers for at least PFC, APP, peer
configuration, buffers and rates.

[1] https://github.com/Mellanox/mlnx-tools/tree/master/ofed_scripts

Petr Machata (15):
  Unify batch processing across tools
  lib: Add parse_one_of(), parse_on_off()
  bridge: link: Port over to parse_on_off()
  lib: Add parse_flag_on_off(), set_flag()
  ip: iplink: Convert to use parse_on_off(), parse_flag_on_off()
  ip: iplink_vlan: Port over to parse_flag_on_off()
  ip: iplink_bridge_slave: Port over to parse_on_off()
  lib: Extract from devlink/mnlg a helper, mnlu_socket_open()
  lib: Extract from devlink/mnlg a helper, mnlu_msg_prepare()
  lib: Extract from devlink/mnlg a helper, mnlu_socket_recv_run()
  lib: Extract from iplink_vlan a helper to parse key:value arrays
  lib: parse_mapping: Update argc, argv on error
  lib: parse_mapping: Recognize a keyword "all"
  Add skeleton of a new tool, dcb
  dcb: Add a subtool for the DCB ETS object

 Makefile                 |   2 +-
 bridge/bridge.c          |  38 +---
 bridge/link.c            |  79 ++++---
 dcb/Makefile             |  24 +++
 dcb/dcb.c                | 379 +++++++++++++++++++++++++++++++++
 dcb/dcb.h                |  36 ++++
 dcb/dcb_ets.c            | 450 +++++++++++++++++++++++++++++++++++++++
 devlink/Makefile         |   2 +-
 devlink/devlink.c        |  41 +---
 devlink/mnlg.c           |  93 ++------
 include/mnl_utils.h      |  11 +
 include/utils.h          |  21 ++
 ip/ip.c                  |  46 +---
 ip/iplink.c              | 182 ++++++----------
 ip/iplink_bridge_slave.c |  12 +-
 ip/iplink_vlan.c         |  86 +++-----
 ip/ipmacsec.c            |  52 +----
 lib/Makefile             |   2 +-
 lib/mnl_utils.c          | 115 ++++++++++
 lib/utils.c              | 114 ++++++++++
 man/man8/dcb-ets.8       | 185 ++++++++++++++++
 man/man8/dcb.8           | 114 ++++++++++
 rdma/rdma.c              |  38 +---
 tc/tc.c                  |  38 +---
 24 files changed, 1652 insertions(+), 508 deletions(-)
 create mode 100644 dcb/Makefile
 create mode 100644 dcb/dcb.c
 create mode 100644 dcb/dcb.h
 create mode 100644 dcb/dcb_ets.c
 create mode 100644 include/mnl_utils.h
 create mode 100644 lib/mnl_utils.c
 create mode 100644 man/man8/dcb-ets.8
 create mode 100644 man/man8/dcb.8

-- 
2.25.1

Powered by blists - more mailing lists