netdev - Re: [PATCH russell-kings-net-queue v2 2/3] net: phy: sfp: add support for multigig RollBall modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201020181438.1b3e972a@kernel.org>
Date:   Tue, 20 Oct 2020 18:14:38 +0200
From:   Marek Behún <kabel@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Russell King - ARM Linux admin <linux@...linux.org.uk>,
        netdev@...r.kernel.org
Subject: Re: [PATCH russell-kings-net-queue v2 2/3] net: phy: sfp: add
 support for multigig RollBall modules

On Tue, 20 Oct 2020 17:51:26 +0200
Andrew Lunn <andrew@...n.ch> wrote:

> > @@ -2006,6 +2040,23 @@ static int sfp_sm_mod_probe(struct sfp *sfp, bool report)
> >  
> >  	sfp->id = id;
> >  
> > +	sfp->phy_addr = SFP_PHY_ADDR;
> > +
> > +	rollball = ((!memcmp(id.base.vendor_name, "OEM             ", 16) ||
> > +		     !memcmp(id.base.vendor_name, "Turris          ", 16)) &&
> > +		    (!memcmp(id.base.vendor_pn, "SFP-10G-T       ", 16) ||
> > +		     !memcmp(id.base.vendor_pn, "RTSFP-10", 8)));  
> 
> Are you customising the SFP, so that it has your vendor name?
> 
> Is the generic SFP OEM/SFP-10G-T, and your customized one Turris/ 
> RTSFP-10?
> 
> 	Andrew

Hilink puts OEM/SFP-10G-T into their modules.
RollBall puts OEM/RTSFP-10 and sometimes OEM/RTSFP-10G.
They are rebranding these modules for us to Turris/RTSFP-10.

Marek