netdev - Re: [PATCH v4] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201019180657.07c2682e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 19 Oct 2020 18:06:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Maxim Kochetkov <fido_max@...ox.ru>
Cc:     netdev@...r.kernel.org, Vladimir Oltean <vladimir.oltean@....com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v4] net: dsa: seville: the packet buffer is 2 megabits,
 not megabytes

On Mon, 19 Oct 2020 08:06:25 +0300 Maxim Kochetkov wrote:
> The VSC9953 Seville switch has 2 megabits of buffer split into 4360
> words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.
> 2 megabits is (2048 / 8) * 1024 = 256 * 1024.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@...ox.ru>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")

Applied, thank you!