netdev - Re: [PATCH net] ibmvnic: no need to update adapter->mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201020164852.722bdedd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 20 Oct 2020 16:48:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Lijun Pan <ljp@...ux.ibm.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ibmvnic: no need to update adapter->mac_addr before
 it completes

On Tue, 20 Oct 2020 18:28:12 -0500 Lijun Pan wrote:
> @@ -1828,7 +1827,6 @@ static int ibmvnic_set_mac(struct net_device *netdev, void *p)
>  	int rc;
>  
>  	rc = 0;
> -	ether_addr_copy(adapter->mac_addr, addr->sa_data);
>  	if (adapter->state != VNIC_PROBED)
>  		rc = __ibmvnic_set_mac(netdev, addr->sa_data);
>  

If we just do this, in case state == VNIC_PROBED ibmvnic_set_mac() will
do nothing - just return 0 without saving the user supplied MAC address.