lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Oct 2020 04:14:42 +0000 From: Joel Stanley <joel@....id.au> To: Dylan Hung <dylan_hung@...eedtech.com> Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Po-Yu Chuang <ratbert@...aday-tech.com>, linux-aspeed <linux-aspeed@...ts.ozlabs.org>, OpenBMC Maillist <openbmc@...ts.ozlabs.org>, BMC-SW <BMC-SW@...eedtech.com> Subject: Re: [PATCH 4/4] ftgmac100: Restart MAC HW once On Mon, 19 Oct 2020 at 08:57, Dylan Hung <dylan_hung@...eedtech.com> wrote: > > The interrupt handler may set the flag to reset the mac in the future, > but that flag is not cleared once the reset has occured. > > Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling") > Signed-off-by: Dylan Hung <dylan_hung@...eedtech.com> > Signed-off-by: Joel Stanley <joel@....id.au> Reviewed-by: Joel Stanley <joel@....id.au> > --- > drivers/net/ethernet/faraday/ftgmac100.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c > index 0c67fc3e27df..57736b049de3 100644 > --- a/drivers/net/ethernet/faraday/ftgmac100.c > +++ b/drivers/net/ethernet/faraday/ftgmac100.c > @@ -1326,6 +1326,7 @@ static int ftgmac100_poll(struct napi_struct *napi, int budget) > */ > if (unlikely(priv->need_mac_restart)) { > ftgmac100_start_hw(priv); > + priv->need_mac_restart = false; > > /* Re-enable "bad" interrupts */ > ftgmac100_write(FTGMAC100_INT_BAD, priv->base + FTGMAC100_OFFSET_IER); > -- > 2.17.1 >
Powered by blists - more mailing lists