netdev - Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+WQbwuHpxpSLK1Y4bTArNm1QxMQ28WQiFT+gyJoN_Neid3sow@mail.gmail.com>
Date:   Wed, 21 Oct 2020 10:37:33 +0800
From:   Geliang Tang <geliangtang@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Peter Krystad <peter.krystad@...ux.intel.com>,
        netdev@...r.kernel.org, mptcp <mptcp@...ts.01.org>,
        "To: Phillip Lougher <phillip@...ashfs.org.uk>, Andrew Morton
        <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, Coly Li
        <colyli@...e.de>, linux-fsdevel@...r.kernel.org," 
        <linux-kernel@...r.kernel.org>
Subject: Re: [MPTCP][PATCH net-next 0/2] init ahmac and port of mptcp_options_received

Hi Jakub,

Jakub Kicinski <kuba@...nel.org> 于2020年10月21日周三 上午7:39写道：
>
> On Mon, 19 Oct 2020 18:23:14 +0800 Geliang Tang wrote:
> > This patchset deals with initializations of mptcp_options_received's two
> > fields, ahmac and port.
>
> Applied, but two extra comments:
>  - please make sure the commit messages are in imperative form
>    e.g. "Initialize x..." rather than "This patches initializes x.."
>  - I dropped the Fixes tag from patch 2, and only queued patch 1 for
>    stable - patch 2 is a minor clean up, right?

Yes, that's right. Thanks for applying and updating the patches.

-Geliang

>
> Thanks!