lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 21 Oct 2020 10:31:00 +0100
From:   Russell King - ARM Linux admin <>
To:     Robert Hancock <>
Subject: Re: [PATCH v3] net: phy: marvell: add special handling of Finisar
 modules with 88E1111

On Tue, Oct 20, 2020 at 06:18:21PM -0600, Robert Hancock wrote:
> The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 88E1111 PHY
> with a modified PHY ID. Add support for this ID using the 88E1111
> methods.
> By default these modules do not have 1000BaseX auto-negotiation enabled,
> which is not generally desirable with Linux networking drivers. Add
> handling to enable 1000BaseX auto-negotiation when these modules are
> used in 1000BaseX mode. Also, some special handling is required to ensure
> that 1000BaseT auto-negotiation is enabled properly when desired.
> Based on existing handling in the AMD xgbe driver and the information in
> the Finisar FAQ:
> Signed-off-by: Robert Hancock <>

Reviewed-by: Russell King <>

One minor issue remains - sorry I didn't spot it last time.  Feel free
to fix that and retain the reviewed by above, no need for an immediate
v4 posting

Please resend when net-next is open, thanks.

> @@ -629,6 +632,51 @@ static int marvell_config_aneg_fiber(struct phy_device *phydev)
>  	return genphy_check_and_restart_aneg(phydev, changed);
>  }
> +static int m88e1111_config_aneg(struct phy_device *phydev)
> +{
> +	int err;
> +	int extsr = phy_read(phydev, MII_M1111_PHY_EXT_SR);

This should be in reverse christmas tree order.

RMK's Patch system:
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Powered by blists - more mailing lists