netdev - Re: [PATCH] net: chelsio: inline_crypto: fix Kconfig and build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201020182010.39f11e21@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 20 Oct 2020 18:20:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Vinay Kumar Yadav <vinay.yadav@...lsio.com>,
        netdev@...r.kernel.org, Ayush Sawal <ayush.sawal@...lsio.com>,
        Rohit Maheshwari <rohitm@...lsio.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: chelsio: inline_crypto: fix Kconfig and build
 errors

On Mon, 19 Oct 2020 11:10:59 -0700 Randy Dunlap wrote:
> Fix build errors when TLS=m, TLS_TOE=y, and CRYPTO_DEV_CHELSIO_TLS=y.
> 
> Having (tristate) CRYPTO_DEV_CHELSIO_TLS depend on (bool) TLS_TOE
> is not strong enough to prevent the bad combination of TLS=m and
> CRYPTO_DEV_CHELSIO_TLS=y, so add a dependency on TLS to prevent the
> problematic kconfig combination.
> 
> Fixes these build errors:
> 
> hppa-linux-ld: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.o: in function `chtls_free_uld':
>  drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:165: undefined reference to `tls_toe_unregister_device'
> hppa-linux-ld: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.o: in function `chtls_register_dev':
> drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:204: undefined reference to `tls_toe_register_device'
> 
> Fixes: 44fd1c1fd821 ("chelsio/chtls: separate chelsio tls driver from crypto driver")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Applied, thanks Randy!

But I swapped the Fixes tag for:

Fixes: 53b4414a7003 ("net/tls: allow compiling TLS TOE out")