netdev - Re: [PATCH] can: j1939: convert PGN structure to a table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Oct 2020 12:33:45 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     yegorslists@...glemail.com, linux-can@...r.kernel.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] can: j1939: convert PGN structure to a table

On 10/22/20 12:29 PM, yegorslists@...glemail.com wrote:
> From: Yegor Yefremov <yegorslists@...glemail.com>
> 
> Use table markup to show the PGN structure.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@...glemail.com>
> ---
>  Documentation/networking/j1939.rst | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
> index faf2eb5c5052..f3fb9d880910 100644
> --- a/Documentation/networking/j1939.rst
> +++ b/Documentation/networking/j1939.rst
> @@ -71,10 +71,14 @@ PGN
>  
>  The PGN (Parameter Group Number) is a number to identify a packet. The PGN
>  is composed as follows:
> -1 bit  : Reserved Bit
> -1 bit  : Data Page
> -8 bits : PF (PDU Format)
> -8 bits : PS (PDU Specific)
> +
> +  ============  ==============  ===============  =================
> +  PGN
> +  ----------------------------------------------------------------
> +  25            24              23 ... 16        15 ... 8

ICan you add a row description that indicated that these numbers are. They are
probably bit positions within the CAN-ID?

> +  ============  ==============  ===============  =================
> +  R (Reserved)  DP (Data Page)  PF (PDU Format)  PS (PDU Specific)
> +  ============  ==============  ===============  =================
>  
>  In J1939-21 distinction is made between PDU1 format (where PF < 240) and PDU2
>  format (where PF >= 240). Furthermore, when using the PDU2 format, the PS-field
> 

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)