netdev - Re: [PATCH] hwmon: (pmbus) Add driver for STMicroelectronics PM6764TR Voltage Regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Oct 2020 15:04:23 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Charles Hsu <hsu.yuegteng@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus) Add driver for STMicroelectronics
 PM6764TR Voltage Regulator

On Thu, Oct 22, 2020 at 07:51:51PM +0800, Charles Hsu wrote:
> Add the pmbus driver for the STMicroelectronics pm6764tr voltage regulator.
> 
> Signed-off-by: Charles Hsu <hsu.yungteng@...il.com>

Hi Charles

Seems a bit odd sending a HWMON driver to the netdev list!


> diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
> index 4c97ad0bd791..bb89fcf9544d 100644
> --- a/drivers/hwmon/pmbus/Makefile
> +++ b/drivers/hwmon/pmbus/Makefile
> @@ -32,3 +32,4 @@ obj-$(CONFIG_SENSORS_UCD9000) += ucd9000.o
>  obj-$(CONFIG_SENSORS_UCD9200) += ucd9200.o
>  obj-$(CONFIG_SENSORS_XDPE122) += xdpe12284.o
>  obj-$(CONFIG_SENSORS_ZL6100) += zl6100.o
> +obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o

This file is sorted. Please don't insert at the end.

> +#define PM6764TR_PMBUS_READ_VOUT 0xD4
> +
> +static int pm6764tr_read_word_data(struct i2c_client *client, int
> page, int reg)
> +{
> + int ret;
> +
> + switch (reg) {
> + case PMBUS_VIRT_READ_VMON:
> + ret = pmbus_read_word_data(client, page,
> +   PM6764TR_PMBUS_READ_VOUT);
> + break;
> + default:
> + ret = -ENODATA;
> + break;
> + }
> + return ret;
> +}


It looks like your mailer has corrupted your patch.

   Andrew