netdev - Re: [PATCH net] tcp: fix to update snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201022104742.5093cce1@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 22 Oct 2020 10:47:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Apollon Oikonomopoulos <apoikos@...sg.gr>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] tcp: fix to update snd_wl1 in bulk receiver fast
 path

On Thu, 22 Oct 2020 13:04:04 -0400 Neal Cardwell wrote:
> > In that case - can I slap:
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> >
> > on it?  
> 
> Yes, slapping that Fixes footer on it sounds fine to me. I see
> that it does apply cleanly to 1da177e4c3f4.

FWIW even if it didn't - my modus operandi is to have the tag pointing
at the earliest point in the git history where the bug exists. Even if
the implementation was completely rewritten - we want to let the people
who run old kernels know they may experience the issue.

Backporters will see the patch doesn't apply and make the right call.

That said I don't think the process documentation is very clear on
this, so maybe someone more experienced will correct my course :)

> Or let me know if you would prefer for me to resubmit a v2 with that footer.

I'll add it, no worries.